-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only view milestones from current repo (#18414) #18418
Merged
zeripath
merged 1 commit into
go-gitea:release/v1.15
from
zeripath:backport-18414-v1.15
Jan 26, 2022
Merged
Only view milestones from current repo (#18414) #18418
zeripath
merged 1 commit into
go-gitea:release/v1.15
from
zeripath:backport-18414-v1.15
Jan 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport go-gitea#18414 The endpoint /{username}/{reponame}/milestone/{id} is not currently restricted to the repo. This PR restricts the milestones to those within the repo. Signed-off-by: Andrew Thornton <[email protected]>
Is it okay that this PR has some code-styling changes in it? |
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jan 26, 2022
as long as lint doesn't care - I don't think it really matters. |
Gusted
approved these changes
Jan 26, 2022
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jan 26, 2022
KN4CK3R
approved these changes
Jan 26, 2022
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jan 26, 2022
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jan 29, 2022
## [1.15.11](https://github.com/go-gitea/gitea/releases/tag/v1.15.11) - 2022-01-29 * SECURITY * Only view milestones from current repo (go-gitea#18414) (go-gitea#18418) * BUGFIXES * Fix broken when no commits and default branch is not master (go-gitea#18422) (go-gitea#18424) * Fix commit's time (go-gitea#18375) (go-gitea#18409) * Fix restore without topic failure (go-gitea#18387) (go-gitea#18401) * Fix mermaid import in 1.15 (it uses ESModule now) (go-gitea#18382) * Update to go/text 0.3.7 (go-gitea#18336) * MISC * Upgrade EasyMDE to 2.16.1 (go-gitea#18278) (go-gitea#18279) Signed-off-by: Andrew Thornton <[email protected]>
Merged
zeripath
added
the
topic/security
Something leaks user information or is otherwise vulnerable. Should be fixed!
label
Jan 29, 2022
6543
pushed a commit
that referenced
this pull request
Jan 30, 2022
## [1.15.11](https://github.com/go-gitea/gitea/releases/tag/v1.15.11) - 2022-01-29 * SECURITY * Only view milestones from current repo (#18414) (#18418) * BUGFIXES * Fix broken when no commits and default branch is not master (#18422) (#18424) * Fix commit's time (#18375) (#18409) * Fix restore without topic failure (#18387) (#18401) * Fix mermaid import in 1.15 (it uses ESModule now) (#18382) * Update to go/text 0.3.7 (#18336) * MISC * Upgrade EasyMDE to 2.16.1 (#18278) (#18279)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
topic/security
Something leaks user information or is otherwise vulnerable. Should be fixed!
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #18414
The endpoint /{username}/{reponame}/milestone/{id} is not currently restricted to
the repo. This PR restricts the milestones to those within the repo.
Signed-off-by: Andrew Thornton [email protected]